-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for encoding extra information in magic token #27
Conversation
@abevoelker the fails look like container hiccups rather than code issues. |
Yeah don’t worry about that, thanks very much for your contribution.
Especially taking the time to include a spec 😀
Going to try to get to it in the next week as well as the rest of the
backlog
…On Fri, May 12, 2023 at 10:14 AM Justin Giancola ***@***.***> wrote:
@abevoelker <https://github.com/abevoelker> the fails look like container
hiccups rather than code issues.
—
Reply to this email directly, view it on GitHub
<#27 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABFO4ZKEUGVZJDPDBDSOZLXFZHVDANCNFSM6AAAAAAX32HHAM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
That's great. Thanks as well. |
Co-authored-by: Jim Kane <jim@util.is>
Co-authored-by: Jim Kane <jim@util.is>
Co-authored-by: Jim Kane <jim@util.is>
I'm currently using this feature in a local fork, and it works great. Thanks for taking the time to share it! |
Hey @elucid, this looks good! Can I ask how you're using it in your application? I'm not that familiar with the insides of Warden and Devise. Are you directly adding to the Cheers |
Thanks for your thoughtful contribution @elucid! This has been merged into a new branch I'm working on for a 1.0.0 release. 🎉 |
Hey there. We have some use cases where we want to store extra information in the token. i.e. an id of a resource the user can claim by clicking on the URL. I wanted to extend the API so that this information can be optionally passed along, and then subsequently made available somewhere on the request env upon successful decode.
Here is an example of using it, adapting the template generated controller code: