Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StreamGear Malformed URI Error with Segments #249

Merged
merged 3 commits into from
Oct 1, 2021

Conversation

Vboivin
Copy link
Contributor

@Vboivin Vboivin commented Sep 30, 2021

Description

  • I removed the extra '%' character from the naming convention for segment files.
  • I removed the Windows carriage returns from the shell scripts to be able to execute them on Linux.

Requirements / Checklist

Related Issue

Closes #248

Context

The segment files are now served without an issue by a server such as Nginx.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Screenshots (if available):

Before Fix

Screenshot-20210930011311-1747x487
Screenshot-20210930011436-644x36

After Fix

Screenshot-20210930011757-1739x403

@welcome
Copy link

welcome bot commented Sep 30, 2021

Thanks so much for opening your first PR here, a maintainer will get back to you shortly!

In the meantime:

@abhiTronix abhiTronix added BUG 🐛 Vidgear api's error, flaw or fault EXEMPLARY 🎖️ Exemplary for newcomers WAITING TO TEST ⏲️ Asked user to test the suggested example/binary/solution WORK IN PROGRESS 🚧 currently been worked on. labels Sep 30, 2021
@abhiTronix abhiTronix added this to the 0.2.3 milestone Sep 30, 2021
@abhiTronix abhiTronix linked an issue Sep 30, 2021 that may be closed by this pull request
3 tasks
@abhiTronix abhiTronix added PENDING TESTS 🧪 Waiting for CI tests to complete successfully. WAITING FOR RESPONSE ⏳ Waiting for the user response. and removed WAITING TO TEST ⏲️ Asked user to test the suggested example/binary/solution labels Sep 30, 2021
@Vboivin
Copy link
Contributor Author

Vboivin commented Sep 30, 2021

@abhiTronix I modified the code to use stream_count to define which segment_template we want to use for the filenames.

@codecov

This comment has been minimized.

@abhiTronix

This comment has been minimized.

Copy link
Owner

@abhiTronix abhiTronix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind you're correct, output_params["stream_count"] value must be greater than 1 and not 0 to detect multi-variant stream.

vidgear/gears/streamgear.py Outdated Show resolved Hide resolved
@abhiTronix
Copy link
Owner

@Vboivin Thanks! Once CI tests are completed successfully, I'll merge it. 👍

@abhiTronix abhiTronix merged commit dc9c60a into abhiTronix:testing Oct 1, 2021
@welcome
Copy link

welcome bot commented Oct 1, 2021

Congrats on merging your first pull request here! 🎉 You're awesome!
Alt Text

@abhiTronix abhiTronix added SOLVED 🏁 This issue/PR is resolved now. Goal Achieved! and removed WORK IN PROGRESS 🚧 currently been worked on. WAITING FOR RESPONSE ⏳ Waiting for the user response. PENDING TESTS 🧪 Waiting for CI tests to complete successfully. labels Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG 🐛 Vidgear api's error, flaw or fault EXEMPLARY 🎖️ Exemplary for newcomers SOLVED 🏁 This issue/PR is resolved now. Goal Achieved!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamGear Malformed URI with Segments
2 participants