Apply suggestions from code review

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
abicky · Oct 28, 2024 · f04c95d · f04c95d
1 parent c5fb1bc
commit f04c95d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/cmd/recreateservice.go b/cmd/recreateservice.go
@@ -66,7 +66,7 @@ func recreateService(cmd *cobra.Command, args []string) error {
 
 	cfg, err := newConfig(cmd.Context())
 	if err != nil {
-		return newRuntimeError("failed to initialize a session: %w", err)
+		return newRuntimeError("failed to initialize configuration: %w", err)
 	}
 
 	if err := service.NewService(ecs.NewFromConfig(cfg)).Recreate(cmd.Context(), cluster, serviceName, overrideDef); err != nil {

diff --git a/internal/service/service.go b/internal/service/service.go
@@ -55,7 +55,7 @@ func (s *Service) Recreate(ctx context.Context, cluster string, serviceName stri
 func (s *Service) copy(ctx context.Context, cluster string, serviceName string, overrides Definition) error {
 	resp, err := s.ecsSvc.DescribeServices(ctx, &ecs.DescribeServicesInput{
 		Cluster:  aws.String(cluster),
-		Include:  []ecstypes.ServiceField{"TAGS"},
+		Include:  []ecstypes.ServiceField{ecstypes.ServiceFieldTags},
 		Services: []string{serviceName},
 	})
 	if err != nil {
@@ -122,7 +122,7 @@ func (s *Service) stopAndWaitUntilStopped(ctx context.Context, cluster string, s
 	taskArns := make([]string, 0)
 	params := &ecs.ListTasksInput{
 		Cluster:       aws.String(cluster),
-		DesiredStatus: "RUNNING",
+		DesiredStatus: ecstypes.DesiredStatusRunning,
 		ServiceName:   aws.String(serviceName),
 	}