-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-5009][CHA-RL1] Room ATTACH #27
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
messages, typing and reactions channel attach fails
extends internal eventemitter
34add29
to
8ffabb1
Compare
…ssing impl. for EventEmitter apply
RoomLifecYCLE management
# Conflicts: # chat-android/src/main/java/com/ably/chat/RoomOptions.kt # chat-android/src/main/java/com/ably/chat/RoomStatus.kt
…ributor across all contributors and initialized RoomLifeCycle inside Room
attach method to call lifecyclemanager attach method instead
1f5623f
to
2c3655a
Compare
…ssing attach suspending method
2c3655a
to
b5a5e54
Compare
Fixed #21