Add update message capability in the SDK, react hooks, and demo app #1634
dev.yml
on: pull_request
audit
20s
format-check
22s
lint
36s
test-typescript
22s
test
1m 13s
build
29s
demo-app
1m 1s
Annotations
14 errors and 15 warnings
test-typescript:
test/react/hooks/use-messages.integration.test.tsx#L1
This expression is not callable because it is a 'get' accessor. Did you mean to use it without '()'?
|
test-typescript:
test/react/hooks/use-messages.test.tsx#L1
Argument of type '{ type: MessageEvents; message: { timestamp: Date; text: string; timeserial: string; action: string; clientId: string; roomId: string; createdAt: Date; isDeleted: Mock<Procedure>; ... 5 more ...; metadata: {}; }; }' is not assignable to parameter of type 'MessageEventPayload'.
|
test-typescript
Process completed with exit code 2.
|
format-check
Process completed with exit code 1.
|
lint:
src/core/message-parser.ts#L94
Missing braces in case clause
|
lint:
src/core/message-parser.ts#L96
Missing braces in case clause
|
lint:
src/core/message-parser.ts#L98
Missing braces in case clause
|
lint:
src/core/message-parser.ts#L98
Use `undefined` instead of `null`
|
lint:
src/core/messages.ts#L157
An interface declaring no members is equivalent to its supertype
|
lint
Process completed with exit code 1.
|
test/core/chat-api.test.ts > config > calls the api with the correct protocol version:
test/core/chat-api.test.ts#L30
AssertionError: expected "request" to be called with arguments: [ 'GET', …(4) ]
Received:
1st request call:
Array [
"GET",
"/chat/v1/rooms/test/occupancy",
3,
- Object {},
+ undefined,
undefined,
]
Number of calls: 1
❯ test/core/chat-api.test.ts:30:34
❯ test/core/chat-api.test.ts:23:5
|
test/core/messages.integration.test.ts > messages integration > should be able to retrieve chat deletion in history:
test/core/messages.integration.test.ts#L192
AssertionError: expected [ DefaultMessage{ …(14) } ] to deeply equal [ ObjectContaining{…} ]
- Expected
+ Received
Array [
- ObjectContaining {
- "clientId": "ably-chat-js-client-68e4ls",
- "deletedAt": 2024-10-23T18:43:27.185Z,
- "deletedBy": "ably-chat-js-client-68e4ls",
- "deletionDetail": Object {
- "description": "Deleted message",
- "metadata": undefined,
+ DefaultMessage {
+ "_calculatedTimeserial": DefaultTimeserial {
+ "counter": 0,
+ "index": 0,
+ "seriesId": "e7d_tzF1ABhlVV06059054",
+ "timestamp": 1729709007170,
},
+ "clientId": "ably-chat-js-client-68e4ls",
+ "createdAt": 2024-10-23T18:43:27.170Z,
+ "deletedAt": undefined,
+ "deletedBy": undefined,
+ "deletionDetail": undefined,
+ "headers": Object {},
+ "metadata": Object {},
+ "roomId": "ably-chat-js-room-44aqait",
"text": "Hello there!",
"timeserial": "e7d_tzF1ABhlVV06059054@1729709007170-0:0",
+ "updateDetail": undefined,
+ "updatedAt": undefined,
+ "updatedBy": undefined,
},
]
❯ test/core/messages.integration.test.ts:192:27
|
test/react/hooks/use-messages.integration.test.tsx > useMessages > should delete messages correctly:
test/react/hooks/use-messages.integration.test.tsx#L127
TypeError: deletionsRoomTwo[0]?.isDeleted is not a function
❯ test/react/hooks/use-messages.integration.test.tsx:127:33
|
test
Process completed with exit code 1.
|
audit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
audit
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
test-typescript
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
test-typescript
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
format-check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
format-check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
lint:
src/react/hooks/use-messages.ts#L109
React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead
|
demo-app
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
demo-app
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v2, actions/setup-node@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|