[CON-84] feat: create conversation SDK #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttypic
force-pushed
the
create-conversation
branch
from
33e14d8
to
add9ff5
Compare
ttypic
force-pushed
the
create-conversation
branch
from
add9ff5
to
3836cb5
Compare
ttypic
changed the title
ttypic
changed the title
AndyTWF
requested changes
Dec 7, 2023
AndyTWF
reviewed
Dec 12, 2023
| @@ -6,9 +6,9 @@ export class Conversations { | |||
| private readonly realtime: Realtime; | |||
| private readonly chatApi: ChatApi; | |||
|
|
|||
| constructor(realtime: Realtime, baseUrl: string) { | |||
| constructor(realtime: Realtime) { | |||
There was a problem hiding this comment.
Should there be a way to pass in a logger here? Perhaps we need to think about introducing something like ClientOptions?
AndyTWF
reviewed
Dec 12, 2023
AndyTWF
approved these changes
Jan 2, 2024
ttypic
force-pushed
the
create-conversation
branch
from
ad40b66
to
7219cf6
Compare
[CON-100] feat: delete message sdk
[CON-96] feat: add conversation caching and some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed API design a bit, rename to conversation, created basic entities