-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chat-core: decrease timeout of the stopTyping timer #361
Conversation
Coverage Report
File Coverage
|
af5bb72
to
7585ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the PR description to say 5 seconds, please?
7585ce6
to
b5468f1
Compare
b5468f1
to
5848fce
Compare
5848fce
to
90888b1
Compare
- 10 seconds seemed a bit excessive after testing, and I think it may confuse developers who incorrectly assume they have to manual call stop() after seeing that the timer doesn't expire after a few seconds. - Reduce timeout to 5 seconds. - Updated the readme in react for clarity.
90888b1
to
84ebd38
Compare
Caution Review failedThe pull request is closed. WalkthroughThe changes involve two primary updates. First, the default timeout for typing events in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Context
stop()
.Description
Checklist
Testing Instructions (Optional)
Summary by CodeRabbit
New Features
ChatClientProvider
andChatRoomProvider
for managing chat contexts.useChatClient
,useMessages
, andusePresence
.Documentation