Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @preconcurrency from ably-cocoa imports #31

Closed
lawrence-forooghian opened this issue Aug 29, 2024 · 0 comments · Fixed by #206
Closed

Remove @preconcurrency from ably-cocoa imports #31

lawrence-forooghian opened this issue Aug 29, 2024 · 0 comments · Fixed by #206
Assignees
@lawrence-forooghian
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Aug 29, 2024 •
edited by sync-by-unito bot
Loading

This is needed to suppress Sendable-related warnings. We can remove them once ably/ably-cocoa#1962 is done.

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the code-quality Affects the developer experience when working in our codebase. label Aug 29, 2024
lawrence-forooghian added a commit that referenced this issue Aug 29, 2024
@lawrence-forooghian
Implement the ability to fetch a room
a1e16c6 
Part of #19. References to spec are based on [1] at commit aa7455d.

The @preconcurrency imports of ably-cocoa are temporary and will be
removed once [2] is done; created #31 for tracking.

I’ve decided to, for now, throw ably-cocoa’s ARTErrorInfo for
consistency with JS; created #32 to revisit this later.

[1] ably/specification#200
[2] ably/ably-cocoa#1962
@lawrence-forooghian lawrence-forooghian mentioned this issue Aug 29, 2024
Merged
lawrence-forooghian added a commit that referenced this issue Aug 29, 2024
@lawrence-forooghian
Implement the ability to fetch a room
5a15ddc 
Part of #19. References to spec are based on [1] at commit aa7455d.

The @preconcurrency imports of ably-cocoa are temporary and will be
removed once [2] is done; created #31 for tracking.

I’ve decided to, for now, throw ably-cocoa’s ARTErrorInfo for
consistency with JS; created #32 to revisit this later.

[1] ably/specification#200
[2] ably/ably-cocoa#1962
lawrence-forooghian added a commit that referenced this issue Aug 29, 2024
@lawrence-forooghian
Implement the ability to fetch a room
6ab6ad3 
Part of #19. References to spec are based on [1] at commit aa7455d.

The @preconcurrency imports of ably-cocoa are temporary and will be
removed once [2] is done; created #31 for tracking.

I’ve decided to, for now, throw ably-cocoa’s ARTErrorInfo for
consistency with JS; created #32 to revisit this later.

[1] ably/specification#200
[2] ably/ably-cocoa#1962
lawrence-forooghian added a commit that referenced this issue Aug 29, 2024
@lawrence-forooghian
Implement DefaultChatClient.rooms
3c35f4f 
The @preconcurrency import of ably-cocoa is temporary and will be
removed once [2] is done; created #31 for tracking.

Part of #19.
lawrence-forooghian added a commit that referenced this issue Aug 29, 2024
@lawrence-forooghian
Implement DefaultChatClient.rooms
202161b 
The @preconcurrency import of ably-cocoa is temporary and will be
removed once [2] is done; created #31 for tracking.

Part of #19.
lawrence-forooghian added a commit that referenced this issue Aug 29, 2024
@lawrence-forooghian
Implement DefaultChatClient.rooms
c50af5d 
The @preconcurrency import of ably-cocoa is temporary and will be
removed once [1] is done; created #31 for tracking.

Part of #19.

[1] ably/ably-cocoa#1962
@lawrence-forooghian lawrence-forooghian self-assigned this Dec 18, 2024
lawrence-forooghian added a commit that referenced this issue Dec 18, 2024
@lawrence-forooghian
Remove @preconcurrency from ably-cocoa imports
31a44ae 
Resolves #31.
@lawrence-forooghian lawrence-forooghian mentioned this issue Dec 18, 2024
Merged
lawrence-forooghian added a commit that referenced this issue Dec 18, 2024
@lawrence-forooghian
Remove @preconcurrency from ably-cocoa imports
0b95632 
No longer needed now that [1] is done.

Resolves #31.

[1] ably/ably-cocoa#1962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
code-quality Affects the developer experience when working in our codebase.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove @preconcurrency from ably-cocoa imports ably/ably-chat-swift
1 participant
@lawrence-forooghian