Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-3701] Fix/missing client options android decoder #473

Merged
merged 5 commits into from
Jul 18, 2023
Merged

[SDK-3701] Fix/missing client options android decoder #473

merged 5 commits into from
Jul 18, 2023

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Jul 6, 2023

Fixed #472

@github-actions github-actions bot temporarily deployed to staging/pull/473/features July 6, 2023 18:02 Inactive
@sacOO7 sacOO7 requested a review from AndyTWF July 6, 2023 18:03
@github-actions github-actions bot temporarily deployed to staging/pull/473/dartdoc July 6, 2023 18:03 Inactive
@sacOO7 sacOO7 requested a review from owenpearson July 6, 2023 18:23
@AndyTWF
Copy link

AndyTWF commented Jul 10, 2023

Looks like we've got some failing CI here?

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jul 10, 2023

Looks like we've got some failing CI here?

Yes, I will check what might be going wrong 👍

@github-actions github-actions bot temporarily deployed to staging/pull/473/features July 10, 2023 17:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/473/dartdoc July 10, 2023 17:18 Inactive
@sacOO7 sacOO7 changed the title Fix/missing client options android decoder [SDK-3701] Fix/missing client options android decoder Jul 12, 2023
@sacOO7 sacOO7 requested a review from andydunstall July 17, 2023 16:40
@owenpearson owenpearson removed the request for review from andydunstall July 17, 2023 16:42
@github-actions github-actions bot temporarily deployed to staging/pull/473/features July 17, 2023 17:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/473/dartdoc July 17, 2023 17:45 Inactive
AndyTWF
AndyTWF approved these changes Jul 18, 2023
View reviewed changes
Copy link

@AndyTWF AndyTWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM - thanks 👍🏻

Looks like we're failing on Android 29, perhaps related to ReactiveCircus/android-emulator-runner#324, although the error is slightly different.

Can you have a look into this? :)

@sacOO7
Copy link
Collaborator Author

sacOO7 commented Jul 18, 2023 •
edited
Loading

Changes LGTM - thanks 👍🏻

Looks like we're failing on Android 29, perhaps related to ReactiveCircus/android-emulator-runner#324, although the error is slightly different.

Can you have a look into this? :)

Actually, I am retrying the build. Most likely related to spawning the emulator. Since, it's an emulator-related issue, not sure what can be done to fix it, other than retrying : (

PS. If the emulator error persists, can be fixed separately, since it's not related to this issue.

owenpearson
owenpearson approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@sacOO7 sacOO7 merged commit 42dec31 into main Jul 18, 2023
@sacOO7 sacOO7 deleted the fix/missing-clientOptions-decoders branch July 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

@AndyTWF AndyTWF AndyTWF approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update android decoder for updated clientOptions
3 participants
@sacOO7 @AndyTWF @owenpearson