Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix realtime connection fields #503

Closed
wants to merge 21 commits into from
Closed

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Feb 21, 2024

@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 21, 2024 17:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 21, 2024 17:03 Inactive
@sacOO7 sacOO7 marked this pull request as ready for review February 21, 2024 17:20
@sacOO7 sacOO7 changed the title Fix/realtime connection fields Fix realtime connection fields Feb 21, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 21, 2024 17:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 21, 2024 17:22 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 21, 2024 17:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 21, 2024 17:37 Inactive
Copy link
Contributor

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Sachin. It works well. However, I don't really like that we've changed existing fields to async props, even if these fields never worked properly.

I think we should either create new async methods with different names as a workaround in the Connection instead or come up with a solution for making them work as fields (similar to state).

lib/src/platform/src/realtime/connection.dart Outdated Show resolved Hide resolved
@maratal
Copy link
Collaborator

maratal commented Feb 21, 2024

I'm not sure what is happening in this PR since as I said I'm not familiar with the flutter codebase, but can't id be set on .connected event? I believe I've seen this handler.

@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 22, 2024 08:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 22, 2024 08:17 Inactive
@sacOO7 sacOO7 force-pushed the fix/realtime-connection-fields branch from 682d4f1 to 5f40d84 Compare February 22, 2024 08:20
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 22, 2024 08:20 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 22, 2024 08:21 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 13:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 13:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 15:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 15:29 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 15:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 15:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 15:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 15:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 15:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 15:44 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 15:49 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 15:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 15:53 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 15:54 Inactive
@sacOO7 sacOO7 force-pushed the fix/realtime-connection-fields branch from 2e05366 to 032948f Compare February 23, 2024 15:56
@github-actions github-actions bot temporarily deployed to staging/pull/503/features February 23, 2024 15:57 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/503/dartdoc February 23, 2024 15:57 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Mar 4, 2024

Marking as resolved, since it's already fixed as a part of #505

@sacOO7 sacOO7 closed this Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

How do we get connectionId from connection?
3 participants