fix: add missing warn logLevel serialization

[ttypic]

Resolves #551

Summary by CodeRabbit

• New Features

  • Enhanced logging capabilities by adding support for the warn log level in the codec's logging mechanism.

• Bug Fixes

  • Improved handling of log levels to ensure accurate processing of the warn log level.

[coderabbitai]

Walkthrough

The changes involve an update to the AblyMessageCodec class within the io.ably.flutter.plugin package. Specifically, the decodeLogLevel method has been modified to include a new case for handling the warn log level from PlatformConstants.TxLogLevelEnum. This enhancement allows the codec to process the warn log level effectively, thereby improving its logging capabilities without altering the overall class structure.

Changes

File Path	Change Summary
android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java	Updated decodeLogLevel method to include a case for PlatformConstants.TxLogLevelEnum.warn.

Poem

In the code where bunnies hop,
A new log level joins the crop.
With warn now in the mix so bright,
Our logs will shine with clearer light.
Hooray for changes, let’s all cheer,
For every level brings us near! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[sacOO7]

LGTM.
Do we need to add test for logging btw, to avoid future exceptions?

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java (1)

401-402: LGTM! Consider adding a comment for clarity.

The addition of the warn case in the decodeLogLevel method correctly implements the missing warn logLevel serialization. This change aligns well with the PR objective.

For improved readability, consider adding a brief comment explaining the purpose of this method, like so:

 private int decodeLogLevel(String logLevelString) {
+    // Convert string log level to integer constant defined in Log class
     if (logLevelString == null) return Log.WARN;
     switch (logLevelString) {
         case PlatformConstants.TxLogLevelEnum.none:

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 4b7e96e and d1ea4a6.

📒 Files selected for processing (1)

• android/src/main/java/io/ably/flutter/plugin/AblyMessageCodec.java (1 hunks)

🧰 Additional context used

[ttypic]

thanks! I don't think it's necessary to cover this with test. If we cover only warn level it won't be very useful, if we cover all serialization keys in flutter it will be too much work