Skip to content

Commit

Permalink
Typings: move unsubscribe from realtimepresencecallbacks to realtimep…
Browse files Browse the repository at this point in the history
…resencebase
  • Loading branch information
SimonWoolf committed Sep 10, 2019
1 parent 75338d2 commit 1624f93
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion ably.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -450,13 +450,13 @@ declare namespace Types {

class RealtimePresenceBase {
syncComplete: boolean;
unsubscribe: (presence?: PresenceAction, listener?: messageCallback<PresenceMessage>) => void;
}

class RealtimePresenceCallbacks extends RealtimePresenceBase {
get: (paramsOrCallback?: realtimePresenceGetCallback | RealtimePresenceParams, callback?: realtimePresenceGetCallback) => void;
history: (paramsOrCallback?: RealtimeHistoryParams | paginatedResultCallback<PresenceMessage>, callback?: paginatedResultCallback<PresenceMessage>) => void;
subscribe: (presenceOrListener: PresenceAction | messageCallback<PresenceMessage> | Array<PresenceAction>, listener?: messageCallback<PresenceMessage>, callbackWhenAttached?: standardCallback) => void;
unsubscribe: (presence?: PresenceAction, listener?: messageCallback<PresenceMessage>) => void;
enter: (data?: errorCallback | any, callback?: errorCallback) => void;
update: (data?: errorCallback | any, callback?: errorCallback) => void;
leave: (data?: errorCallback | any, callback?: errorCallback) => void;
Expand Down
2 changes: 1 addition & 1 deletion common/lib/client/realtimechannel.js
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ var RealtimeChannel = (function() {
Message.decode(msg, options);
} catch (e) {
/* decrypt failed .. the most likely cause is that we have the wrong key */
Logger.logAction(Logger.LOG_ERROR, 'RealtimeChannel.onMessage()', e.toString());
Logger.logAction(Logger.LOG_MINOR, 'RealtimeChannel.onMessage()', e.toString());
}
if(!msg.connectionId) msg.connectionId = connectionId;
if(!msg.timestamp) msg.timestamp = timestamp;
Expand Down

0 comments on commit 1624f93

Please sign in to comment.