-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove soft-deprecated APIs in 2.0 branch #1197
Labels
breaking
Backwards incompatible changes made to the public API.
Comments
mikelee638
added
the
breaking
Backwards incompatible changes made to the public API.
label
Apr 20, 2023
➤ Automation for Jira commented: The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3546 |
lawrence-forooghian
added a commit
that referenced
this issue
Apr 26, 2023
The library never reads this property. This work was scheduled as part of ably-js v2, but it appears safe to do it in v1. Part of #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
After removing the testing of wsHost’s effect, everything in the test that this commit removes is tested in the subsequent test. Part of #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
These are properties which have been removed from the public API of the SDK, but which internal and test code still use for modifying the behaviour of the SDK via its public constructors. In the case where users were specifying these properties when using v1 of the library, we want these properties to cease to have any effect upon upgrading to v2. Hence we move them into a new `internal:` namespace. I hope that it’s safe to assume that users are not going to pass a set of options that for some reason has a property named `internal`. Part of #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
These are properties which have been removed from the public API of the SDK, but which internal and test code still use for modifying the behaviour of the SDK via its public constructors. In the case where users were specifying these properties when using v1 of the library, we want these properties to cease to have any effect upon upgrading to v2. Hence we move them into a new `internal:` namespace. I hope that it’s safe to assume that users are not going to pass a set of options that for some reason has a property named `internal`. Part of #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
These are properties which have been removed from the public API of the SDK, but which internal and test code still use for modifying the behaviour of the SDK via its public constructors. In the case where users were specifying these properties when using v1 of the library, we want these properties to cease to have any effect upon upgrading to v2. Hence we move them into a new `internal:` namespace. I hope that it’s safe to assume that users are not going to pass a set of options that for some reason has a property named `internal`. Part of #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
Remove the ability to call it without a key, or to pass a key without wrapping it in a CipherParamOptions object. Resolves #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
Remove the ability to call it without a key, or to pass a key without wrapping it in a CipherParamOptions object. Resolves #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
After removing the testing of wsHost’s effect, everything in the test that this commit removes is tested in the subsequent test. Part of #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
These are properties which have been removed from the public API of the SDK, but which internal and test code still use for modifying the behaviour of the SDK via its public constructors. In the case where users were specifying these properties when using v1 of the library, we want these properties to cease to have any effect upon upgrading to v2. Hence we move them into a new `internal:` namespace. I hope that it’s safe to assume that users are not going to pass a set of options that for some reason has a property named `internal`. Part of #1197.
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
lawrence-forooghian
added a commit
that referenced
this issue
Apr 27, 2023
Remove the ability to call it without a key, or to pass a key without wrapping it in a CipherParamOptions object. Resolves #1197.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Remove currently soft-deprecated features from the library. Examples include but are not necessarily limited to:
authOptions
ClientOptions
fromcommon/types/ClientOptions.ts
The text was updated successfully, but these errors were encountered: