Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for JSONP in 2.0 branch #1198

Closed
mikelee638 opened this issue Apr 20, 2023 · 2 comments
Closed

Remove support for JSONP in 2.0 branch #1198

mikelee638 opened this issue Apr 20, 2023 · 2 comments
Assignees
@lawrence-forooghian
Labels
breaking Backwards incompatible changes made to the public API.

Comments

@mikelee638
Copy link

Internal queries show that no one is using JSONP and due to this, we have decided to remove it from the library in the next major version update.
@mikelee638 mikelee638 added the breaking Backwards incompatible changes made to the public API. label Apr 20, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Apr 20, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3547

lawrence-forooghian added a commit that referenced this issue Apr 26, 2023
@lawrence-forooghian
Remove support for JSONP
3551441 
As #1198 says, "Internal queries show that no one is using JSONP and due
to this, we have decided to remove it from the library in the next major
version update."

Note that in both the web and nodejs platforms,
Defaults.baseTransportOrder and Defaults.transportPreferenceOrder now
have identical contents. I considered combining them into a single
property, but I couldn’t think of a way of expressing the two separate
concepts that I think these properties are trying to express — that is,
"transport most likely to be supported" and "transport we’d most like to
use".  So I’ve kept them separate.

Resolves #1198.
@lawrence-forooghian lawrence-forooghian mentioned this issue Apr 26, 2023
Merged
@lawrence-forooghian
Copy link
Collaborator

Closed in #1215.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lawrence-forooghian lawrence-forooghian

Labels
breaking Backwards incompatible changes made to the public API.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikelee638 @lawrence-forooghian