-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node build without crypto or buffertools #332
Comments
You could take a similar approach to |
@mattheworiordan possible be more explicit ? Here is the error from AWS lambda
|
@leozc that note was for Simon to look at, probably not something we could easily explain how you can do it. Can you wait till early next week as we may be able to make a release that does not depend on buffertools? |
@SimonWoolf we need to look at this on Monday as @paddybyers has confirmed Buffertools is not needed (Node.js 4.3.2 on Lambda has Buffer support, it was introduced in 0.11!). Also, it seems crypto is part of Node.js core so shouldn't be an issue. We need to remove BufferTools and check that it works in Lambda, then bump a release and add a note that we no longer support Node < 0.11 |
Fixed by #340, released as part of ably-js 0.8.38. |
https://app.intercom.io/a/apps/ua39m1ld/inbox/all/conversations/5952016749 has made me wonder if we should offer a node package without cryptojs and buffertools (like ably.noencryption.js for the browser), for usecases like using on AWS Lambda, where large package sizes (npm package is > 10MB at the moment, mostly cryptojs)) and having natively compiled modules are a pain.
The text was updated successfully, but these errors were encountered: