Node build without crypto and buffertools #340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddybyers
reviewed
Oct 11, 2016
| var nodeBufferCompare = function(buf1, buf2) { | ||
| if(!buf1) return -1; | ||
| if(!buf2) return 1; | ||
| return require('buffertools').compare(buf1, buf2); |
There was a problem hiding this comment.
But since this was written we have https://nodejs.org/api/buffer.html#buffer_buf_compare_target_targetstart_targetend_sourcestart_sourceend
for node > 0.11.13
It's only used when generating the browser lib
|
even easier then. We can even keep the min required node version at 0.10.x, since bufferCompare is only called by tests. |
SimonWoolf
added a commit
that referenced
this pull request
Oct 12, 2016
|
Merged as 2ec5f45 |
|
Nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That was a lot easier than I was expecting. Turns out node wasn't actually using either buffertools or crypto-js at all at runtime. So could basically just move them both from dependencies to devDependencies