'variable data is undeclared' when attempting to use Google Closure Compiler

[ashpr]

So I'm trying to build a project of ours using ably and compress it via google closure compiler.

It throws the following error:

stdin:136807: ERROR - variable data is undeclared
if (typeof(data) == 'string')

I found it's this line here..

ably-js/common/lib/types/message.js

Line 67 in d502382

if (typeof(data) == 'string')

I think 'data' is meant to be 'this.data'.. if this could be changed that would be terrific.

[funkyboy]

Thanks @ashpr for reporting this.
We also are using the closure compiler to build our minified version

Just curious, which version are you using? Here's ours: https://github.com/ably/ably-js/blob/master/package.json#L26

[ashpr]

Here's the version I'm using bundled with the closure plugin for Webpack
https://github.com/roman01la/webpack-closure-compiler/blob/master/package.json#L27

So I'm two released versions ahead.

I did find this in the patch notes for v20180319

Stricter "strictMissingProperty" checks.

See here: https://github.com/google/closure-compiler/wiki/Releases

I suspect that might have something to do with it.

Thanks for acknowledging this @funkyboy !

[funkyboy]

@ashpr I just tried with your version and it still works. It's not related to the version number but to the compilation_level.

We are using SIMPLE_OPTIMIZATIONS and I am guessing you are using ADVANCED_OPTIMIZATIONS. Correct?

[SimonWoolf]

@funkyboy this is a bit of a moot point, the line ashpr pointed out is clearly wrong and needs to be fixed regardless

[funkyboy]

@SimonWoolf sure. The reason I am asking is that I don't get only that error when I take up a notch the optimization level.

>>
>> browser/static/ably.js:5023: ERROR - variable data is undeclared
>>                      if (typeof(data) == 'string')
>>                                 ^^^^
>>
>> browser/static/ably.js:8464: ERROR - variable Buffer is undeclared
>>              toBase64 = function(str) { return (new Buffer(str, 'ascii')).toString('base64'); };
>>                                                     ^^^^^^
>>
>> browser/static/ably.js:11503: ERROR - variable exports is undeclared
>> if (typeof exports === "object" && exports) {
>>            ^^^^^^^
>>
>> browser/static/ably.js:11515: ERROR - variable define is undeclared
>> if (typeof define === "function" && define.amd) {
>>            ^^^^^^
>>
>> 4 error(s), 10 warning(s)
>> FAILED to run command for target: ably.js
Warning: Task "closureCompiler:ably.js" failed. Use --force to continue.

Aborted due to warnings.
ably-js>

[ashpr]

@funkyboy You are correct. I only get that error in advanced builds.

Nothing else comes up I'm afraid. I have an extern for the exports variable but nothing for the define and Buffer variables so i'm not sure why they are not being flagged.

The GCC NPM repo does come pre-loaded with nodejs externs that may be automatically injected but I can't find any kind of logging to confirm.

[funkyboy]

@ashpr Good. This change has been merged and will be included in the next release.

[ashpr]

Thank you @funkyboy . Much appreciated!