Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry timer is improperly cleared, causing it to fail to start the second time #898

Closed
Peter-Maguire opened this issue Feb 24, 2022 · 0 comments · Fixed by #899
Closed

Retry timer is improperly cleared, causing it to fail to start the second time #898

Peter-Maguire opened this issue Feb 24, 2022 · 0 comments · Fixed by #899
Assignees
@Peter-Maguire
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@Peter-Maguire
Copy link
Contributor

Peter-Maguire commented Feb 24, 2022 •
edited by sync-by-unito bot
Loading

cancelRetryTimer clears the timeout but incorrectly sets suspendTimer to null instead of retryTimer, so the second time that the retry timer is called (if the connection is lost, regained, then lost again) it will not start, meaning that the channel will not try to re-attach

┆Issue is synchronized with this Jira Bug by Unito
@Peter-Maguire Peter-Maguire added the bug Something isn't working. It's clear that this does need to be fixed. label Feb 24, 2022
@Peter-Maguire Peter-Maguire self-assigned this Feb 24, 2022
@Peter-Maguire Peter-Maguire linked a pull request Feb 24, 2022 that will close this issue
fix retry timer setting wrong variable to null (Fixes #898) #899
Merged
Peter-Maguire pushed a commit that referenced this issue Feb 24, 2022
Merge pull request #899 from ably/fix-retry-timer-bug
24ef7de 
fix retry timer setting wrong variable to null (Fixes #898)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Peter-Maguire Peter-Maguire

Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix retry timer setting wrong variable to null (Fixes #898) ably/ably-js
1 participant
@Peter-Maguire