eventemitter: fix once with array using promise #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1046/bundle-report
andydunstall
force-pushed
the
bugfix/event-emitter-with-promise
branch
from
d5cb5f0
to
0b33753
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when looking at upgrading the realtime test suite to use the latest SDK found
await conn.once(['foo', 'bar'])no longer works using promises, throwingInvalid arguments(though callbacks is fine ieconn.once(['foo', 'bar'], () => {})looks like a check was added in 32f8d04#diff-21811b221b0e30b57b9d5c084d2fd83f1709eb97a129e25732474b92b8fb63a6R237 - though I can't see what this is checking given its just calling itself so will be checked later (or if its just so typescript doesn't complain)?