New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align exposed type of ErrorInfo with internal type #1142

Merged

owenpearson merged 1 commit into ably:main from JCB-K:jacob/error-type

Mar 2, 2023

Contributor

JCB-K commented Mar 2, 2023

The type of the ErrorInfo class was incorrect when using the library, due to the ably.d.ts not being in sync with

Not sure if I did this right - is it okay to edit ably.d.ts manually?


          fix: align exposed type of ErrorInfo with internal type

553830e

owenpearson approved these changes

View reviewed changes

Member

owenpearson left a comment

Ah good spot and thanks for the PR 🙂 and yes, ably.d.ts isn't generated or anything so manually editing it is fine 👍

owenpearson merged commit b2991c4 into ably:main

JCB-K deleted the jacob/error-type branch

March 6, 2023 12:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet