[SDK-3560] Add mandatory version param to Rest.request
#1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
fb34429
to
6354d9d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
6354d9d
to
d1c9ca9
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
d1c9ca9
to
f828bc6
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
f828bc6
to
53c94d1
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
53c94d1
to
5e6accb
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
5e6accb
to
fe44cd3
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
fe44cd3
to
1e11659
Compare
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
1e11659
to
bcf8711
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1231/bundle-report
I intend to add further optional params and this will allow us to disambiguate them.
As described by RSC19f1 in ably/specification at commit 505238c. The docstrings are taken from ably/sdk-api-reference at commit 1e0776e. The corresponding PR [1] has been approved by Owen but is still awaiting tech writer approval. So we might need to tweak these docstrings later, but I don’t think that needs to block us on this feature. Approach for mocking HTTP request handling copied from http.test.js. Other than the added test, the test changes are minimal (just adding an extra argument to a few calls) but Prettier has decided to do some re-indentation that makes them look larger than they are. Resolves #1225. [1] ably/sdk-api-reference#32
lawrence-forooghian
force-pushed
the
1225-add-version-param-to-Rest.request
branch
from
bcf8711
to
ba77bfb
Compare
lawrence-forooghian
changed the title
version param to Rest.request and Realtime.requestversion param to Rest.request
Peter-Maguire
approved these changes
May 3, 2023
hayleynewton
changed the title
version param to Rest.requestversion param to Rest.request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1225. See commit messages for more details.