Remove the CryptoJS library #1326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed as of 11a4a39.
We do this by making IPlatformConfig.getRandomValues mandatory. Since we’re now targeting modern browsers, we can get rid of the TypedArray checks and the accessing of the msCrypto object.
We’re no longer making use of this library (in order to reduce bundle size, given that modern browsers provide all of the necessary crypto functionality). Resolves #1239.
|
Sorry, marked this one as ready for review too soon, ignore! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this is based on top of #1325; please review that one first.
This completely removes our usage of the CryptoJS library. See commit messages for more details.
Resolves #1239.