Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3570] Remove CryptoJS library #1333

Merged
merged 5 commits into from
Jun 19, 2023

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Jun 12, 2023

We’re no longer making use of this library (in order to reduce bundle size, given that modern browsers provide all of the necessary crypto functionality).

See commit messages for more details.

Resolves #1239.

@github-actions github-actions bot temporarily deployed to staging/pull/1333/features June 12, 2023 12:11 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1333/bundle-report June 12, 2023 12:12 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1333/typedoc June 12, 2023 12:13 Inactive
Base automatically changed from 1295-stop-using-CryptoJS-for-signing-token-requests to integration/v2 June 12, 2023 12:52
@github-actions github-actions bot temporarily deployed to staging/pull/1333/features June 13, 2023 10:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1333/bundle-report June 13, 2023 10:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1333/typedoc June 13, 2023 10:45 Inactive
Preparation for #1239 (removing CryptoJS dependency).
Preparation for #1239 (removing CryptoJS dependency).
We’re no longer making use of this library (in order to reduce bundle
size, given that modern browsers provide all of the necessary crypto
functionality).

Resolves #1239.
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice

@lawrence-forooghian lawrence-forooghian merged commit 4931665 into integration/v2 Jun 19, 2023
@lawrence-forooghian lawrence-forooghian deleted the 1239-remove-CryptoJS-library branch June 19, 2023 12:26
@hayleynewton hayleynewton changed the title Remove CryptoJS library [SDK-3570] Remove CryptoJS library Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants