-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3570] Remove CryptoJS library #1333
Merged
lawrence-forooghian
merged 5 commits into
integration/v2
from
1239-remove-CryptoJS-library
Jun 19, 2023
Merged
[SDK-3570] Remove CryptoJS library #1333
lawrence-forooghian
merged 5 commits into
integration/v2
from
1239-remove-CryptoJS-library
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1333/bundle-report
June 12, 2023 12:12
Inactive
Base automatically changed from
1295-stop-using-CryptoJS-for-signing-token-requests
to
integration/v2
June 12, 2023 12:52
lawrence-forooghian
force-pushed
the
1239-remove-CryptoJS-library
branch
from
June 13, 2023 10:43
d493337
to
ad1e808
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1333/bundle-report
June 13, 2023 10:45
Inactive
lawrence-forooghian
force-pushed
the
integration/v2
branch
from
June 13, 2023 13:46
7bea01e
to
b8e1ea3
Compare
No longer needed as of 11a4a39.
Preparation for #1239 (removing CryptoJS dependency).
Preparation for #1239 (removing CryptoJS dependency).
We’re no longer making use of this library (in order to reduce bundle size, given that modern browsers provide all of the necessary crypto functionality). Resolves #1239.
lawrence-forooghian
force-pushed
the
1239-remove-CryptoJS-library
branch
from
June 13, 2023 13:49
ad1e808
to
f1bf748
Compare
owenpearson
approved these changes
Jun 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice
hayleynewton
changed the title
Remove CryptoJS library
[SDK-3570] Remove CryptoJS library
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We’re no longer making use of this library (in order to reduce bundle size, given that modern browsers provide all of the necessary crypto functionality).
See commit messages for more details.
Resolves #1239.