Convert WordArrays to ArrayBuffers when msgpack-encoding #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
err .. makes it interoperable, because sending a map would never work except for other browser clients. |
| var uint8View = new Uint8Array(arrayBuffer); | ||
|
|
||
| for (var i = 0; i < buf.sigBytes; i++) { | ||
| uint8View[i] = (buf.words[i >>> 2] >>> (24 - (i % 4) * 8)) & 0xff; |
There was a problem hiding this comment.
This still isn't great efficiency-wise, because we should be writing words into a unit32View, but we can leave this and file a lower-priority issue to improve it unless you want to do it now anyway.
There was a problem hiding this comment.
It is definitely not worth optimising now, let's please land this as it works and performance of this obscure requirement for now is not a high priority
|
Nice work |
paddybyers
added a commit
that referenced
this pull request
Sep 30, 2015
Convert WordArrays to ArrayBuffers when msgpack-encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142, and makes msgpack more efficient when used with encryption, as encrypted binary data is encoded as binary data rather than as arrays of ints.
The actual bit-packing code already existed in the 3.x development branch of the google code project, but the version on github (which is what's packaged on npm) was forked from the 3.1.2 release, which doesn't have it. For simplicity I just copied & pasted the relevant code into bufferutils.