Do e013cc0’s typescript-eslint version bumps in package.json
#1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that they don’t get lost next time we need to do something that may cause information in package-lock.json to get discarded, for example resolving a merge conflict. I asked whether my approach in e013cc0 was incorrect, and Owen said he thought it was: "i'm pretty sure what you're supposed to do is put anything you want to control the version of into package.json", so let’s do that.
owenpearson
approved these changes
Nov 9, 2023
lawrence-forooghian
deleted the
do-e013cc0-typescript-eslint-bumps-in-package-json
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do e013cc0’s
typescript-eslintversion bumps inpackage.json, so that they don’t get lost next time we need to do something that may cause information inpackage-lock.jsonto get discarded, for example resolving a merge conflict.I asked whether my approach in e013cc0 was incorrect, and Owen said he thought it was:
So let’s do that.