Presence map: normalise enter/update actions to present in #put #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -259,6 +258,10 @@ var RealtimePresence = (function() { | |||
| }; | |||
|
|
|||
| PresenceMap.prototype.put = function(item) { | |||
| if(Utils.arrIn([presenceAction.ENTER, presenceAction.UPDATE], item.action)) { | |||
There was a problem hiding this comment.
This might look elegant but it's hopelessly inefficient compared to just doing (x==a || x==b).
SimonWoolf
force-pushed
the
presence-event-fix
branch
from
ed82bd4
to
87441e3
Compare
Neater than juggling different broadcast and map-member presence messages in #setPresence Fixes presence test failures broken by 9c4f8d7
SimonWoolf
force-pushed
the
presence-event-fix
branch
from
87441e3
to
51f4885
Compare
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITSM should be the presence map's responsibility to normalise its actions - neater than juggling different broadcast and map-member presence messages in #setPresence
Fixes presence tests broken by 9c4f8d7