-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3975] Log all HTTP activity #1581
Commits on Jan 16, 2024
-
It’s just an implementation detail of the web class.
Configuration menu - View commit details
-
Copy full SHA for 272ab42 - Browse repository at this point
Copy the full SHA 272ab42View commit details -
It’s just an implementation detail of the Node class.
Configuration menu - View commit details
-
Copy full SHA for 2a840c0 - Browse repository at this point
Copy the full SHA 2a840c0View commit details
Commits on Jan 18, 2024
-
I’m going to introduce a platform-agnostic class called Http.
Configuration menu - View commit details
-
Copy full SHA for 5dce7f7 - Browse repository at this point
Copy the full SHA 5dce7f7View commit details -
Create a platform-agnostic HTTP client
This will hold HTTP-related functionality that’s shared across platforms, such fallback host usage or logging.
Configuration menu - View commit details
-
Copy full SHA for 6db96f6 - Browse repository at this point
Copy the full SHA 6db96f6View commit details -
Use doUri inside web’s HTTP.do
Makes it consistent with the Node version.
Configuration menu - View commit details
-
Copy full SHA for aef1771 - Browse repository at this point
Copy the full SHA aef1771View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eda771 - Browse repository at this point
Copy the full SHA 8eda771View commit details -
Tighten the type of HTTP request body a bit
Looked into what types we pass, because I wanted to understand it better for some logging that I’m going to add. Thought I might as well update the types to reflect what I’d found out.
Configuration menu - View commit details
-
Copy full SHA for e86ebf9 - Browse repository at this point
Copy the full SHA e86ebf9View commit details -
Base64 encode binary data when logging response
To avoid loss of information when unprintable characters (e.g. in MessagePack responses) get replaced (either by console.log or by the terminal, not sure which) with U+FFFD.
Configuration menu - View commit details
-
Copy full SHA for 7cd8580 - Browse repository at this point
Copy the full SHA 7cd8580View commit details -
Use
inspect
when printing Resource response bodyElse we often just see "[object Object]" in the logs.
Configuration menu - View commit details
-
Copy full SHA for 258af9a - Browse repository at this point
Copy the full SHA 258af9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f36f537 - Browse repository at this point
Copy the full SHA f36f537View commit details -
Owen requested this during a review of #1526, which strips most of our logging from the modular variant of the SDK, but aims to still log all network activity. A bonus benefit is that we now also have logging for requests which get tried against different hosts, which we previously didn’t. The log statements are adaptations of the existing ones in resource.ts.
Configuration menu - View commit details
-
Copy full SHA for d43f965 - Browse repository at this point
Copy the full SHA d43f965View commit details