-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-4039] Make modulereport
print gzipped size too
#1586
Merged
lawrence-forooghian
merged 4 commits into
integration/v2
from
1580-modulereport-gzip-too
Jan 24, 2024
Merged
[SDK-4039] Make modulereport
print gzipped size too
#1586
lawrence-forooghian
merged 4 commits into
integration/v2
from
1580-modulereport-gzip-too
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1586/features
January 19, 2024 16:16
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1586/typedoc
January 19, 2024 16:17
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1586/bundle-report
January 19, 2024 16:17
Inactive
lawrence-forooghian
changed the title
Make
[SDK-4039] Make Jan 23, 2024
modulereport
print gzipped size toomodulereport
print gzipped size too
lawrence-forooghian
force-pushed
the
1580-modulereport-gzip-too
branch
from
January 24, 2024 10:33
261ae07
to
85b70d3
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1586/features
January 24, 2024 10:33
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1586/typedoc
January 24, 2024 10:34
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1586/bundle-report
January 24, 2024 10:34
Inactive
Just pushed a couple of other commits, to format as a table and add the size of a bundle that includes all modules (a piece of information that @ttypic indicated would be useful to have). |
lawrence-forooghian
force-pushed
the
1580-modulereport-gzip-too
branch
from
January 24, 2024 10:41
85b70d3
to
d77e356
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1586/features
January 24, 2024 10:42
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1586/typedoc
January 24, 2024 10:42
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1586/bundle-report
January 24, 2024 10:42
Inactive
VeskeR
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, let's merge after minor changes
lawrence-forooghian
force-pushed
the
1580-modulereport-gzip-too
branch
from
January 24, 2024 14:01
d77e356
to
792e10b
Compare
VeskeR
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It’s quite likely that some of our users will be serving their bundles with gzip encoding, so this is useful information to have.
Example output
Resolves #1580.