Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-4039] Make modulereport print gzipped size too #1586

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

lawrence-forooghian
Copy link
Collaborator

@lawrence-forooghian lawrence-forooghian commented Jan 19, 2024

It’s quite likely that some of our users will be serving their bundles with gzip encoding, so this is useful information to have.

Example output
> ably@1.2.48 modulereport
> tsc --noEmit scripts/moduleReport.ts && esr scripts/moduleReport.ts

Minimal useful Realtime (BaseRealtime + FetchRequest + WebSocketTransport): raw: 107.68 KiB; gzip: 31.15 KiB
BaseRest: raw: 59.12 KiB; gzip: 18.52 KiB
BaseRest + Rest: raw: 59.12 KiB; gzip: 18.52 KiB
BaseRest + Crypto: raw: 62.66 KiB; gzip: 19.76 KiB
BaseRest + MsgPack: raw: 67.88 KiB; gzip: 20.62 KiB
BaseRest + RealtimePresence: raw: 86.54 KiB; gzip: 25.73 KiB
BaseRest + XHRPolling: raw: 77.17 KiB; gzip: 23.75 KiB
BaseRest + XHRStreaming: raw: 77.17 KiB; gzip: 23.75 KiB
BaseRest + WebSocketTransport: raw: 72.06 KiB; gzip: 22.08 KiB
BaseRest + XHRRequest: raw: 66.24 KiB; gzip: 20.80 KiB
BaseRest + FetchRequest: raw: 60.16 KiB; gzip: 18.96 KiB
BaseRest + MessageInteractions: raw: 60.36 KiB; gzip: 18.93 KiB
BaseRest + Vcdiff: raw: 66.55 KiB; gzip: 20.63 KiB
BaseRest + generateRandomKey: raw: 62.69 KiB; gzip: 19.77 KiB
BaseRest + getDefaultCryptoParams: raw: 62.69 KiB; gzip: 19.77 KiB
BaseRest + decodeMessage: raw: 59.46 KiB; gzip: 18.63 KiB
BaseRest + decodeEncryptedMessage: raw: 62.99 KiB; gzip: 19.85 KiB
BaseRest + decodeMessages: raw: 59.56 KiB; gzip: 18.65 KiB
BaseRest + decodeEncryptedMessages: raw: 63.10 KiB; gzip: 19.88 KiB
BaseRest + decodePresenceMessage: raw: 59.30 KiB; gzip: 18.56 KiB
BaseRest + decodePresenceMessages: raw: 59.40 KiB; gzip: 18.58 KiB
BaseRest + constructPresenceMessage: raw: 59.13 KiB; gzip: 18.53 KiB
BaseRealtime: raw: 103.10 KiB; gzip: 29.69 KiB
BaseRealtime + Rest: raw: 122.58 KiB; gzip: 34.47 KiB
BaseRealtime + Crypto: raw: 106.64 KiB; gzip: 30.93 KiB
BaseRealtime + MsgPack: raw: 111.86 KiB; gzip: 31.78 KiB
BaseRealtime + RealtimePresence: raw: 113.14 KiB; gzip: 32.19 KiB
BaseRealtime + XHRPolling: raw: 111.61 KiB; gzip: 32.36 KiB
BaseRealtime + XHRStreaming: raw: 111.61 KiB; gzip: 32.36 KiB
BaseRealtime + WebSocketTransport: raw: 106.63 KiB; gzip: 30.70 KiB
BaseRealtime + XHRRequest: raw: 106.83 KiB; gzip: 31.05 KiB
BaseRealtime + FetchRequest: raw: 104.14 KiB; gzip: 30.13 KiB
BaseRealtime + MessageInteractions: raw: 104.34 KiB; gzip: 30.08 KiB
BaseRealtime + Vcdiff: raw: 110.53 KiB; gzip: 31.79 KiB
BaseRealtime + generateRandomKey: raw: 106.67 KiB; gzip: 30.95 KiB
BaseRealtime + getDefaultCryptoParams: raw: 106.67 KiB; gzip: 30.95 KiB
BaseRealtime + decodeMessage: raw: 103.44 KiB; gzip: 29.80 KiB
BaseRealtime + decodeEncryptedMessage: raw: 106.98 KiB; gzip: 31.04 KiB
BaseRealtime + decodeMessages: raw: 103.54 KiB; gzip: 29.82 KiB
BaseRealtime + decodeEncryptedMessages: raw: 107.08 KiB; gzip: 31.06 KiB
BaseRealtime + decodePresenceMessage: raw: 104.60 KiB; gzip: 29.98 KiB
BaseRealtime + decodePresenceMessages: raw: 104.70 KiB; gzip: 30.01 KiB
BaseRealtime + constructPresenceMessage: raw: 104.43 KiB; gzip: 29.95 KiB
generateRandomKey: raw: 38.94 KiB; gzip: 13.60 KiB
generateRandomKey + Crypto: raw: 38.94 KiB; gzip: 13.59 KiB
getDefaultCryptoParams: raw: 38.94 KiB; gzip: 13.59 KiB
getDefaultCryptoParams + Crypto: raw: 38.94 KiB; gzip: 13.59 KiB
decodeMessage: raw: 38.34 KiB; gzip: 13.31 KiB
decodeEncryptedMessage: raw: 41.88 KiB; gzip: 14.56 KiB
decodeEncryptedMessage + Crypto: raw: 41.88 KiB; gzip: 14.56 KiB
decodeMessages: raw: 38.45 KiB; gzip: 13.35 KiB
decodeEncryptedMessages: raw: 41.98 KiB; gzip: 14.59 KiB
decodeEncryptedMessages + Crypto: raw: 41.98 KiB; gzip: 14.58 KiB
decodePresenceMessage: raw: 38.51 KiB; gzip: 13.42 KiB
decodePresenceMessages: raw: 38.61 KiB; gzip: 13.44 KiB
constructPresenceMessage: raw: 36.51 KiB; gzip: 12.68 KiB

Resolves #1580.

@github-actions github-actions bot temporarily deployed to staging/pull/1586/features January 19, 2024 16:16 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1586/typedoc January 19, 2024 16:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1586/bundle-report January 19, 2024 16:17 Inactive
@lawrence-forooghian lawrence-forooghian marked this pull request as ready for review January 19, 2024 16:20
@lawrence-forooghian lawrence-forooghian changed the title Make modulereport print gzipped size too [SDK-4039] Make modulereport print gzipped size too Jan 23, 2024
@github-actions github-actions bot temporarily deployed to staging/pull/1586/features January 24, 2024 10:33 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1586/typedoc January 24, 2024 10:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1586/bundle-report January 24, 2024 10:34 Inactive
@lawrence-forooghian
Copy link
Collaborator Author

Just pushed a couple of other commits, to format as a table and add the size of a bundle that includes all modules (a piece of information that @ttypic indicated would be useful to have).

@github-actions github-actions bot temporarily deployed to staging/pull/1586/features January 24, 2024 10:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1586/typedoc January 24, 2024 10:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1586/bundle-report January 24, 2024 10:42 Inactive
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, let's merge after minor changes

scripts/moduleReport.ts Outdated Show resolved Hide resolved
scripts/moduleReport.ts Outdated Show resolved Hide resolved
Not sure why I added this in 63f5524.
It’s quite likely that some of our users will be serving their bundles
with gzip encoding, so this is useful information to have.

Resolves #1580.
Seems like useful information to have.
@lawrence-forooghian lawrence-forooghian merged commit 49b9f40 into integration/v2 Jan 24, 2024
10 of 12 checks passed
@lawrence-forooghian lawrence-forooghian deleted the 1580-modulereport-gzip-too branch January 24, 2024 16:10
@VeskeR VeskeR mentioned this pull request Mar 1, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants