fix: should reattach channel logic #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1608/features
github-actions
bot
temporarily deployed
to
staging/pull/1608/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1608/typedoc
ttypic
force-pushed
the
fix-should-reattach-logic
branch
from
3a4d13f
to
a32e5cb
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1608/features
github-actions
bot
temporarily deployed
to
staging/pull/1608/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1608/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1608/features
github-actions
bot
temporarily deployed
to
staging/pull/1608/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1608/typedoc
ttypic
force-pushed
the
fix-should-reattach-logic
branch
from
26ec7d4
to
a0b4fea
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1608/features
github-actions
bot
temporarily deployed
to
staging/pull/1608/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1608/typedoc
ttypic
force-pushed
the
fix-should-reattach-logic
branch
from
a0b4fea
to
37ad334
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1608/features
github-actions
bot
temporarily deployed
to
staging/pull/1608/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1608/bundle-report
owenpearson
requested changes
Feb 5, 2024
`_shouldReattachToSetOptions` used `this.params` and `this.modes` when checking channel options, but these fields are only set after the channel is attached. This created a bug when `RealtimeChannels.get()` is invoked during `attaching` state.
ttypic
force-pushed
the
fix-should-reattach-logic
branch
from
37ad334
to
6b5d083
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1609
Jira links SDK-4075
_shouldReattachToSetOptionsusedthis.paramsandthis.modeswhen checking channel options, but these fields are only set after the channel is attached. This created a bug whenRealtimeChannels.get()is invoked duringattachingstate.