-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ECO-4121] Publicly document v2 platform compatibility and update CI accordingly #1633
Conversation
I'm not sure about this place in README:
Should we remove it entirely or reword it somehow? Currently it does imply that we support much older versions than we listed above. At the same time we do still have comet transport in codebase in case websockets doesn't work, even though all of the browser versions we support have websockets API available. |
I think that this statement is misleading. My understanding is that browser compatibility is only one of the reasons that we support alternative (i.e. non-WebSocket) transports. The other is that there are potential network conditions (firewalls or proxies are the ones I’ve seen talked about) that might block WebSocket connections (see the documentation for
This statement seems to no longer be accurate — there are no issues using that label and it doesn't appear in our guidance about which labels to use. So I think we can remove that part of the statement. |
I didn't know about that, thank you! Now it makes sense why we still need comet transport code even after switching to newer platforms. Yea, I will reword that paragraph and find a better place for it then. No reason for it to be in the supported platforms section.
Will remove. |
26db010
to
e0f37de
Compare
Removed fallback transport paragraph from this PR. Also applied other changes. |
After switching to ES2017 build target in 54d4c39, ES5 classes in NodeCometTransport were causing "Uncaught TypeError: Class constructor CometTransport cannot be invoked without 'new'" errors in CI [1]. [1] https://github.com/ably/ably-js/actions/runs/8049569753/job/21984635358?pr=1633
e0f37de
to
b445729
Compare
Also removes comment about old browsers support as it's not needed after #1633
Resolves #1605
Changes: