feat: no upgrade #1645
Merged
feat: no upgrade #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1645/features
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1645/typedoc
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
1823fbe
to
606ffa6
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1645/features
github-actions
bot
temporarily deployed
to
staging/pull/1645/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
606ffa6
to
4a8250d
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1645/features
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1645/typedoc
owenpearson
requested review from
SimonWoolf,
VeskeR,
ttypic and
lawrence-forooghian
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
4a8250d
to
3eb3704
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1645/features
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1645/typedoc
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
3eb3704
to
36b2b97
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1645/features
github-actions
bot
temporarily deployed
to
staging/pull/1645/typedoc
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
36b2b97
to
6c5cc48
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1645/features
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/1645/typedoc
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
6c5cc48
to
bdf8750
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1645/features
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
|
@SimonWoolf I've addressed the feedback in #1645 (review) by setting the value of |
that's within a |
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
f3ffb80
to
63523db
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1645/bundle-report
|
@SimonWoolf Good point, I've made it so that |
|
@owenpearson just a heads up that depending on which PR gets merged first you might need to also update the migration guide (see #1670) |
SimonWoolf
approved these changes
Mar 19, 2024
owenpearson
force-pushed
the
no-upgrade-v2
branch
from
63523db
to
b54bcf5
Compare
This was referenced May 22, 2024
Closed
VeskeR
added a commit
that referenced
this pull request
Sep 6, 2024
…ycle Fixes a regression introduced in ably-js v2 in the "no upgrade" PR [1]. Under certain network conditions (internet down) a race condition could occur in the connection manager. Specifically, websocket connectivity check in the `startWebSocketSlowTimer` function needed to set the `wsCheckResult` flag to `false` before the timer was cleared by other code branches. If that happened, it then caused an endless loop of websocket connection retries, even after the network conditions stabilized. A websocket transport would successfully open but then be immediately disposed due to the `wsCheckResult` flag still being set to `false`, without any mechanism to reset it in this scenario. Upon closer look, it makes sense that the websocket connection health flags (`wsCheckResult` and `abandonedWebSocket`) should be reset when attempting a new websocket connection. The previous solution did not explicitly reset these flags in the `connectWs` function, leading to the described race condition and endless loop. Thus, `wsCheckResult` and `abandonedWebSocket` are now reset to their neutral values upon entering the `connectWs` function. Resolves #1844 [1] #1645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira links:
removes XHRStreaming transport, replaces upgrade mechanism with a websocket + base fallback transport mechanism whereby no two transports may be simultaneously connected.