Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rea 1808 unsubscribe from channel group #1651

Conversation

mschristensen
Copy link
Contributor

No description provided.

@github-actions github-actions bot temporarily deployed to staging/pull/1651/features February 28, 2024 17:41 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1651/bundle-report February 28, 2024 17:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1651/typedoc February 28, 2024 17:42 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1651/features February 28, 2024 18:17 Inactive
@mschristensen mschristensen force-pushed the feature/REA-1808-unsubscribe-from-channel-group branch from 4b5806f to 5d868c9 Compare February 28, 2024 18:17
@github-actions github-actions bot temporarily deployed to staging/pull/1651/features February 28, 2024 18:18 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1651/bundle-report February 28, 2024 18:19 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1651/typedoc February 28, 2024 18:19 Inactive
Similar to the active channel, we need to avoid conflicts.
We store the current active set of members in the hashring.
Messages can be delivered more than once during a consumer group
rescaling event, so deduplicate the results when checking the end
condition.
Copy link
Contributor

@VeskeR VeskeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the surface level LGTM.
Only a comment about error logging

src/common/lib/client/baserealtime.ts Outdated Show resolved Hide resolved
src/common/lib/client/baserealtime.ts Outdated Show resolved Hide resolved
@mschristensen mschristensen merged commit e5ffcc6 into experimental-v2/channel-and-consumer-group Mar 1, 2024
7 of 12 checks passed
@mschristensen mschristensen deleted the feature/REA-1808-unsubscribe-from-channel-group branch March 1, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants