-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rea 1808 unsubscribe from channel group #1651
Merged
mschristensen
merged 10 commits into
experimental-v2/channel-and-consumer-group
from
feature/REA-1808-unsubscribe-from-channel-group
Mar 1, 2024
Merged
Feature/rea 1808 unsubscribe from channel group #1651
mschristensen
merged 10 commits into
experimental-v2/channel-and-consumer-group
from
feature/REA-1808-unsubscribe-from-channel-group
Mar 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1651/features
February 28, 2024 17:41
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1651/bundle-report
February 28, 2024 17:42
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1651/typedoc
February 28, 2024 17:42
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1651/features
February 28, 2024 18:17
Inactive
mschristensen
force-pushed
the
feature/REA-1808-unsubscribe-from-channel-group
branch
from
February 28, 2024 18:17
4b5806f
to
5d868c9
Compare
github-actions
bot
temporarily deployed
to
staging/pull/1651/features
February 28, 2024 18:18
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1651/bundle-report
February 28, 2024 18:19
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1651/typedoc
February 28, 2024 18:19
Inactive
Similar to the active channel, we need to avoid conflicts.
We store the current active set of members in the hashring.
Messages can be delivered more than once during a consumer group rescaling event, so deduplicate the results when checking the end condition.
github-actions
bot
temporarily deployed
to
staging/pull/1651/features
February 28, 2024 19:16
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1651/bundle-report
February 28, 2024 19:17
Inactive
github-actions
bot
temporarily deployed
to
staging/pull/1651/typedoc
February 28, 2024 19:17
Inactive
VeskeR
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the surface level LGTM.
Only a comment about error logging
VeskeR
approved these changes
Mar 1, 2024
mschristensen
merged commit Mar 1, 2024
e5ffcc6
into
experimental-v2/channel-and-consumer-group
7 of 12 checks passed
mschristensen
deleted the
feature/REA-1808-unsubscribe-from-channel-group
branch
March 1, 2024 14:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.