Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECO-4644] Rename id field to ablyId in React Hooks #1676

Merged
merged 4 commits into from
Mar 11, 2024
Merged

[ECO-4644] Rename id field to ablyId in React Hooks #1676

merged 4 commits into from
Mar 11, 2024

Conversation

VeskeR
Copy link
Contributor

@VeskeR VeskeR commented Mar 8, 2024 •
edited
Loading

Resolves #1637

Also does minor type refactoring in React Hooks

@github-actions github-actions bot temporarily deployed to staging/pull/1676/features March 8, 2024 08:50 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1676/typedoc March 8, 2024 08:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1676/bundle-report March 8, 2024 08:51 Inactive
@VeskeR VeskeR mentioned this pull request Mar 8, 2024
Merged
@VeskeR VeskeR marked this pull request as ready for review March 8, 2024 09:05
@VeskeR VeskeR requested a review from ttypic March 8, 2024 09:05
@VeskeR VeskeR changed the title Rename id field to ablyId in React Hooks [ECO-4644] Rename id field to ablyId in React Hooks Mar 8, 2024
ttypic
ttypic approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ttypic ttypic mentioned this pull request Mar 8, 2024
Merged
@VeskeR
Copy link
Contributor Author

VeskeR commented Mar 11, 2024

Updated react hooks docs to also include ablyId

@VeskeR VeskeR requested a review from ttypic March 11, 2024 12:12
ttypic
ttypic approved these changes Mar 11, 2024
View reviewed changes
Copy link
Collaborator

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VeskeR VeskeR merged commit 9720015 into integration/v2 Mar 11, 2024
12 checks passed
@VeskeR VeskeR deleted the 1637/rename-id-in-react-hooks branch March 11, 2024 12:16
This was referenced Mar 11, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VeskeR @ttypic