-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: react-native TextEncoder/TextDecoder polyfill + restore package.json react-native field #1713
Conversation
credit to @VeskeR Keeping the exports field for react-native too since this is experimentally supported.
c96e524
to
a52972a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
And just a heads-up, see Lawrence's comment about writing "Resolves #[issue number]" for multiple issues:
Also, just a heads-up that writing "Resolves #1538 , #1332" in your PR description doesn't do what you think it does — you need to write "Resolves #1538, resolves #1332".
Those fields were removed in de5ddfa and replaced with `exports` field we currently use. However, removal of root level entry fields from `package.json` have caused issues with importing `ably` in some setups: - React Native wasn't able to resolve `ably` at all, due to `exports` field resolution is not enabled by default yet [1] (we fixed this by re-adding root level `react-native` field in #1713) - older bundler versions do not support `exports` field, for example, webpack has added support for `exports` only in v5. - TypeScript added support for resolving `exports` field only in its 4.7 release [2] This commit re-adds root level entry fields so those setups will still be able to resolve `ably` package. Resolves #1751 [1] https://reactnative.dev/blog/2023/06/21/package-exports-support [2] https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing
Those fields were removed in de5ddfa and replaced with `exports` field we currently use. However, removal of root level entry fields from `package.json` have caused issues with importing `ably` in some setups: - React Native wasn't able to resolve `ably` at all, due to `exports` field resolution is not enabled by default yet [1] (we fixed this by re-adding root level `react-native` field in #1713) - older bundler versions do not support `exports` field, for example, webpack has added support for `exports` only in v5. - TypeScript added support for resolving `exports` field only in its 4.7 release [2] This commit re-adds root level entry fields so those setups will still be able to resolve `ably` package. Resolves #1751 [1] https://reactnative.dev/blog/2023/06/21/package-exports-support [2] https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing
Resolves #1712, #1711 (Jira https://ably.atlassian.net/browse/ECO-4710)
Contains two fixes for react-native support in v2: