fix: react-native TextEncoder/TextDecoder polyfill + restore package.json react-native field #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/1713/bundle-report
credit to @VeskeR Keeping the exports field for react-native too since this is experimentally supported.
owenpearson
force-pushed
the
react-native-v2-fixes
branch
from
c96e524
to
a52972a
Compare
VeskeR
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
LGTM.
And just a heads-up, see Lawrence's comment about writing "Resolves #[issue number]" for multiple issues:
Also, just a heads-up that writing "Resolves #1538 , #1332" in your PR description doesn't do what you think it does — you need to write "Resolves #1538, resolves #1332".
VeskeR
added a commit
that referenced
this pull request
Jun 3, 2024
Those fields were removed in de5ddfa and replaced with `exports` field we currently use. However, removal of root level entry fields from `package.json` have caused issues with importing `ably` in some setups: - React Native wasn't able to resolve `ably` at all, due to `exports` field resolution is not enabled by default yet [1] (we fixed this by re-adding root level `react-native` field in #1713) - older bundler versions do not support `exports` field, for example, webpack has added support for `exports` only in v5. - TypeScript added support for resolving `exports` field only in its 4.7 release [2] This commit re-adds root level entry fields so those setups will still be able to resolve `ably` package. Resolves #1751 [1] https://reactnative.dev/blog/2023/06/21/package-exports-support [2] https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing
VeskeR
added a commit
that referenced
this pull request
Jun 3, 2024
Those fields were removed in de5ddfa and replaced with `exports` field we currently use. However, removal of root level entry fields from `package.json` have caused issues with importing `ably` in some setups: - React Native wasn't able to resolve `ably` at all, due to `exports` field resolution is not enabled by default yet [1] (we fixed this by re-adding root level `react-native` field in #1713) - older bundler versions do not support `exports` field, for example, webpack has added support for `exports` only in v5. - TypeScript added support for resolving `exports` field only in its 4.7 release [2] This commit re-adds root level entry fields so those setups will still be able to resolve `ably` package. Resolves #1751 [1] https://reactnative.dev/blog/2023/06/21/package-exports-support [2] https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1712, #1711 (Jira https://ably.atlassian.net/browse/ECO-4710)
Contains two fixes for react-native support in v2: