ConnectionManager.ping(): rewrite to fix pings stacking if none ever succeed #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…succeed previously if the transport keeps becoming active but then gets disconnected before the ping succeeds, listeners would just keep stacking up the whole previous implementation is way over-complex now we no longer do transport upgrades. replaced with a much simpler one.
|
(this seems to have failed the linter github action because of a |
owenpearson
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Looks good 👍
w.r.t npm audit --production in CI, we opted for this a while ago because it helps us to be aware of vulnerabilities in prod deps faster (which seems to still work - we found out about it here before anyone saw the dependabot alert). The intended solution is for someone to fix it in the main branch and then rebase this PR, but I think it's fine to merge this PR with admin rights anyway as long as everything else is passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously if the transport keeps becoming active but then gets disconnected before the ping succeeds, listeners would just keep stacking up
the whole previous implementation was just way over-complex now we no longer do transport upgrade. rewrote from scratch with a much simpler promise-based one.