Remove presence leaveOnDisconnect test #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not testing an ably-js feature -- this is realtime's responsibility
SimonWoolf
force-pushed
the
remove-leave-on-disconnect
branch
from
1641817
to
d6838da
Compare
SimonWoolf
added a commit
that referenced
this pull request
Dec 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thing this is testing is that realtime broadcasts a
leaveevent when a connection closes. That's not an ably-js feature, and there's not much ably-js can do when it starts failing. So: I want to remove it from ably-js and add it to realtime, where it'll be better at catching realtime regressions.