Don’t activate a transport that isn’t connected #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonWoolf
force-pushed
the
transportfailurerace
branch
from
b0dce71
to
3c628e7
Compare
| * scheduleTransportActivation#onceNoPending wait) then don't activate it */ | ||
| if(!transport.isConnected) { | ||
| Logger.logAction(Logger.LOG_MINOR, 'ConnectionManager.activateTransport()', 'Declining to activate transport ' + transport + ' since it appears to no longer be connected'); | ||
| Utils.arrDeleteValue(this.pendingTransports, transport); |
There was a problem hiding this comment.
I think I would have reversed the order of these things; ie unconditionally remove from the pendingTransports list, then decline to activate + return if not connected.
|
LGTM but see comment above. |
SimonWoolf
force-pushed
the
transportfailurerace
branch
from
3c628e7
to
21d9604
Compare
SimonWoolf
added a commit
that referenced
this pull request
Apr 5, 2016
|
Merged as c2a4912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247