Dynamic auth #269
Merged
Dynamic auth #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2016
Closed
regex failed for connectionKeys with exclamation marks, negative
connection serials, etc. Client lib shouldn't assume anything about the
format of the connection key except that it doesn't contain a colon, so
a simple split(':') is safest
You can't use the same recoveryKey more than once, so unpersist after a successful recovery. Also stop persisting on connect: should only be useful in browsers that don't support beforeunload, but that's a subset of browsers that don't support sessionstorage, so not much point
as ably-js tests emit beforeunload events to test on-page-refresh functionality
|
Made the lastConnectionDetails |
This was referenced Jun 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines some existing PRs with some other misc fixes to support the dynamic-auth realtime changes.
#267
#266
#261