Add "lib=js-x.x.xx" qs param to connectParams #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@SimonWoolf any reason not to simply add the header at the same time, see ably-js/common/lib/util/utils.js Line 294 in be8ac97 |
|
@mattheworiordan None at all (I vaguely thought we'd decided not to add the header for now on the call, but I think I just misremembered). c624fbd |
SimonWoolf
added a commit
that referenced
this pull request
Jul 6, 2016
|
Have you got an issue to add that back in @SimonWoolf? |
|
looks like the frontend change made it into production at the weekend, so I'll just add it back in master now |
Ok, great, please do a release as well then. |
|
Released 0.8.26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.