Fix presence messages ending an in-progress sync #319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported by Larry where a large room would occasionally show far too few presence members (within a region - separate from inter-region sync issues). Turns out that a presence message arriving in the middle of a sync would interrupt the sync.
(I reused the
broadcast
parameter fromsetPresence
, since it wasn't actually used anywhere in the function. I'm assuming it's leftover from some previous design for presence and is now defunct)