Webpack support + remove legacy compat libraries #321
Conversation
| @@ -1,6 +1,6 @@ | |||
| var JSONPTransport = (function() { | |||
| var noop = function() {}; | |||
| var _ = window.Ably._ = {}; | |||
| var _ = Ably._ = {}; | |||
There was a problem hiding this comment.
This will break the jsonp transport unfortunately, it currently relies on there being a window.Ably object.
yay. Great to know I added some value there :) |
SimonWoolf
force-pushed
the
webpack-support
branch
from
e7e9cf5
to
2afa34c
Compare
|
Thanks Matt :) 👍 except for the jsonp issue. Not sure what the best solution is there. I've added commit 84ddef1 which fixes the issue, though is a bit ugly (it uses |
| @@ -94,7 +105,7 @@ var JSONPTransport = (function() { | |||
| params = this.params, | |||
| self = this; | |||
|
|
|||
| params.callback = 'Ably._._(' + id + ')'; | |||
| params.callback = jsonpcb + '._(' + id + ')'; | |||
There was a problem hiding this comment.
Nice. I had a niggling feeling the JSONP needed to be treated differently, but in the end skipped over it :/
|
Great. @SimonWoolf do you want to merge & publish? |
|
@SimonWoolf should we merge this? can you do it? |
|
Sorry, forgot about this |
@SimonWoolf this resolves #318 and #307
I'm yet to see what impact it has on the CI build, but from testing locally it seems to be working fine so far.
cc @paddybyers