Limit node http agent socket pool to 25 #336
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So assuming a round trip time of 500ms, and a max number of in-flight requests of 25 - that's a hard-coded maximum sustainable throughput of 50 requests per second from a single library instance. Is it reasonable to have a limit in this way? |
SimonWoolf
force-pushed
the
limit-parallel-tcp
branch
from
66f0130
to
7d7831e
Compare
|
After discussion with Paddy, increased limit from 25 to 40, and made a hidden |
|
That looks good to me 👍 |
paddybyers
reviewed
Sep 20, 2016
| @@ -144,7 +145,8 @@ this.Http = (function() { | |||
| * @param callback (err, response) | |||
| */ | |||
| Http.postUri = function(rest, uri, headers, body, params, callback) { | |||
| var postOptions = {headers:headers, body:body, encoding:null, forever: true}; | |||
| var agentOptions = (rest && rest.options.restAgentOptions) || Defaults.restAgentOptions; | |||
| var postOptions = {headers:headers, body:body, encoding:null, forever: true, agentOptions: agentOptions}; | |||
There was a problem hiding this comment.
I prefer a space after the colon, but at least be consistent :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a reasonable limit on the max number of parallel TCP connections for doing rest requests with (by default there's no limit) seems to eliminate the TCP errors and timeouts we were seeing when hundreds of rest requests are fired off in parallel.
I'm open to input on the exact value. With 50 I was still seeing a couple TCP spurious retransmissions with 500 parallel publishes; with 25, no TCP errors; and a socket pool of 25 is large enough for reasonable parallelism (500 simple publishes end up with starting times spread out over around around 2 seconds, which seems not unreasonable).