Stop network error trading a token request for a token failing the connection #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
common/lib/client/auth.js
Outdated
| @@ -437,6 +437,11 @@ var Auth = (function() { | |||
| tokenRequest(tokenRequestOrDetails, function(err, tokenResponse, headers, unpacked) { | |||
| if(err) { | |||
| Logger.logAction(Logger.LOG_ERROR, 'Auth.requestToken()', 'token request API call returned error; err = ' + Utils.inspectError(err)); | |||
| if(!(err && err.code)) { | |||
There was a problem hiding this comment.
I find this logic odd to read, wouldn't if(err && !err.code) make it simpler to comprehend, or have I misunderstood what this is doing?
There was a problem hiding this comment.
since it's inside the if(err) check then surely we just need if(!err.code) ?
SimonWoolf
force-pushed
the
network-error-failed
branch
from
29c5bc8
to
d5bffc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. customer report at https://app.intercom.io/a/apps/ua39m1ld/respond/inbox/all/conversations/12117963267