Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make auth failures only send realtime conns to FAILED if 403 #434

Merged
merged 4 commits into from
Nov 21, 2017

Conversation

SimonWoolf
Copy link
Member

Implements ably/docs#322

@SimonWoolf SimonWoolf changed the title https://github.com/ably/docs/pull/322 Make auth failures only send realtime conns to FAILED if 403 Nov 21, 2017
mixin = helper.Utils.mixin;
mixin = helper.Utils.mixin,
echoServer = "http://echo.ably.io";
//echoServer = "http://localhost:5000";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is necessary, but I suppose it doesn't matter

Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM, 👍

@SimonWoolf SimonWoolf merged commit 2832e88 into master Nov 21, 2017
SimonWoolf added a commit that referenced this pull request Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants