Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ws to v5 #525

Closed
wants to merge 1 commit into from
Closed

Update ws to v5 #525

wants to merge 1 commit into from

Conversation

SimonWoolf
Copy link
Member

paddybyers
paddybyers approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Does this place any constraint on the node versions we support?

@SimonWoolf
Copy link
Member Author

Does this place any constraint on the node versions we support?

Was about to say no (I checked it still supported 4.x before putting the pr up), but on closer investigation, yes: it requires v4.5 (for Buffer.alloc), we currently support back to v4.2.

Their justification is that older 4.x's have security holes so people on 4.x should upgrade to 4.8.7 or 4.9.1 anyway.

WDYT?

@paddybyers
Copy link
Member

Their justification is that older 4.x's have security holes so people on 4.x should upgrade to 4.8.7 or 4.9.1 anyway.

WDYT?

I think it's fine for us to exclude those older versions - we just ought to document that.

@SimonWoolf
Copy link
Member Author

Fixed + readme & engines updated in 99c967e

@SimonWoolf SimonWoolf closed this Aug 23, 2018
@SimonWoolf SimonWoolf deleted the update-ws branch August 23, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paddybyers paddybyers paddybyers approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonWoolf @paddybyers