Fix bug where connectionSerial was not getting reset after a resume failure #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigated one instance of
ConnectionMaster.syncForRequest_08() | Unexpected error getting channel backlog; err = [ErrorInfo: Invalid message id; statusCode=400; code=40007 ((fatal))], and it turned out to be a bug in ably-js: the connectionSerial was not getting reset back to -1 after a failed resume. (A single connection is then the cause of many instances of that log line -- one for every resume or transport upgrade after that until the number of messages received on the new connection catches up with the connectionSerial of the old).