Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings: lots of type definition fixes #695

Merged
merged 4 commits into from
Nov 3, 2020
Merged

Typings: lots of type definition fixes #695

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47d1f9e
Typings: fix type def of ChannelOptions (everything is optional)
SimonWoolf Nov 3, 2020
e3e952d
Typings: fix typings of Crypto interface
SimonWoolf Nov 3, 2020
90b58ca
Typings: fix defn of recover clientoption
SimonWoolf Nov 3, 2020
e07e9d1
Typings: rewrite callback typings
SimonWoolf Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ably.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,9 +253,9 @@ declare namespace Types {
type ChannelModes = Array<ChannelMode>;

interface ChannelOptions {
cipher: any;
params: ChannelParams;
modes: ChannelModes;
cipher?: {key: ArrayBuffer | Uint8Array | string} | CipherParams;
params?: ChannelParams;
modes?: ChannelModes;
}

interface RestHistoryParams {
Expand Down