Fix request typings #731
Merged
Fix request typings #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonWoolf
reviewed
Mar 26, 2021
| @@ -651,8 +651,7 @@ declare namespace Types { | |||
| isLast: () => boolean; | |||
| } | |||
|
|
|||
| class HttpPaginatedResponse extends PaginatedResult<any> { | |||
| items: string[]; | |||
| class HttpPaginatedResponse<T = any> extends PaginatedResult<T> { | |||
| statusCode: number; | |||
There was a problem hiding this comment.
You accidentally deleted the items line instead of changing it to items: T[];..?
There was a problem hiding this comment.
PaginatedResult actually has its own items property which is already typed as T[] so deleting this line has the same effect but without duplication
|
I've not got enough TypeScript knowledge to make an informed approval on this pull request, so I think just ensure that @SimonWoolf is happy. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #728.
Also adds a generic type parameter for
Rest.requestto declare the response type for convenience.