-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webworker support #756
Webworker support #756
Conversation
Oh, but 1 question: would this prevent a regression in the future? I made an environment here which crashed with the |
@ben-xD Yeah this should be fairly regression-proof - I can't think of an obvious way to break it, although the webpack 'webworker' target isn't well documented so it's hard to say for certain. I actually tested against your ably-webworker repo when I was developing this so it should work, have you checked that you're using the |
Okay cool. Im not facing any issues anymore because I've switched to Firebase functions which runs in a nodeJS environment. The way I phrased my last sentence makes it sound like I tried your fix, but I didn't because I've moved to Firebase functions. I was just mentioning my observations of the crash before your fix, I wrote that sentence badly, sorry. But I've tested it now, so I've observed a few things:
Unrelated issue:
|
Thanks, I'm aware of the typings issue and need to investigate what the current best approach is. At the moment we have a separate type definitions file for each module you can import (see And yes, the |
To reproduce,
Cool, I will make a github issue for the other issue |
I'm currently adding Ably to a Cloudflare worker and running into think is this issue:
Is there an old version of Ably that does work in Cloudflare Workers? |
Hey @jcapogna,
@owenpearson will know more |
Hi @jcapogna, thanks for reporting this to us. As Ben said above |
Thank you, downgrading to 1.2.3 helped. I'm now having what I believe to be a different problem w/ Ably & Cloudflare so I opened #766 |
Were we going to add typescript support for this one? There is no autocomplete when using the webworker import, so all the usages everything is a red squiggly line. When I was using it, I commented out the webworker import and used the normal import during development/ coding, and uncommented to build it. Having said that, if typescript support is coming through other means it's probably not a big deal to wait for that. |
Oops I read the commit log upside down 🙃, I've tested it now, and it works. Thanks! |
Webworker support is currently broken, a regression from the move to webpack. This PR adds a new webpack bundle which specifically supports running in a webworker context.