fix channel names as object prototype keys #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/777/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/777/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/777/bundle-report
Matt-Esch
force-pushed
the
me-fix-object-channel-id
branch
from
013849d
to
19111ec
Compare
github-actions
bot
temporarily deployed
to
staging/pull/777/bundle-report
Matt-Esch
force-pushed
the
me-fix-object-channel-id
branch
from
19111ec
to
a7406ca
Compare
github-actions
bot
temporarily deployed
to
staging/pull/777/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/777/bundle-report
owenpearson
approved these changes
Jul 29, 2021
Matt-Esch
force-pushed
the
me-fix-object-channel-id
branch
from
6d39b6c
to
9a2e2ab
Compare
github-actions
bot
temporarily deployed
to
staging/pull/777/bundle-report
Matt-Esch
force-pushed
the
me-fix-object-channel-id
branch
from
9a2e2ab
to
b87c2ce
Compare
|
I think I have satisfied myself that these tests are unaffected by the changes I've made so please go ahead and merge this for me please @owenpearson - I have fixed a few of the tests, I got to the point of debugging firefox tests and that's a bit too deep in the weeds at this point. I have at least seen passing tests for node 10/12/14 so if you're happy with this let's get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an object key is free-form text, we should not use vanilla js objects, as this can cause key collisions with built-in prototype keys, such as
__proto__ortoString, etc. I have offered a quick solution for this issue, but it would be better tackled using an ES6Map. I am happy for someone to replace these structures with Map instances if they would prefer. I'm not familiar with which versions of js we support and whether we would want aMappolyfill if things are being back-ported (babel?) for < ES6 compatibility.